1079782 - Apply Call status bar styles as designed.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Victoria Gerchinhoren [:vicky]]

Attachment: Visual Mockup: Call_Status_bar

Call status bar should follow the specifications in order to speak the app's same language and interact well with the rest of the OS.
Visual design and specs for implementation are provided.

Comment 1

[Victoria Gerchinhoren [:vicky]]

Attachment: Visual Spec: Call_Status_bar

Comment 2

[Victoria Gerchinhoren [:vicky]]

Attachment: Loop icon for the call status bar in 4 sizes.

Comment 3

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Comment 4

[Cristian Rodriguez (:crdlc)]

Maria Angeles, I changed here a string just in case it ends in 1.1

See https://github.com/mozilla-b2g/firefoxos-loop-client/pull/211/files#diff-964b329a1e6469f66cec3e4991fbb538R94

Comment 5

[Maria Angeles Oteo (:oteo)]

(In reply to Cristian Rodriguez (:crdlc) from comment #4)
> Maria Angeles, I changed here a string just in case it ends in 1.1
> 
> See
> https://github.com/mozilla-b2g/firefoxos-loop-client/pull/211/files#diff-
> 964b329a1e6469f66cec3e4991fbb538R94

ok, thanks!
Let's it land in master first and if there is not any issues we will uplift it to 1.1 branch

Comment 6

[Borja Salguero [:borjasalguero]]

Attachment: bar.png

Vicky, could you confirm the UI is the right one? Thanks!

Comment 7

[Borja Salguero [:borjasalguero]]

Please address as well https://github.com/mozilla-b2g/firefoxos-loop-client/pull/211/files#r19076046 before merging. THanks!

Comment 8

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8507758 [details]
bar.png

"hello" word should be regular style if text (400), counter is missing and also, can you provide the screenshot of the case when the call is muted or on hold? I need to see how the respective icons are placed.

Thanks!

Comment 9

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8507758 [details]
bar.png

Also, the system status bar should be visible, right?

Comment 10

[Cristian Rodriguez (:crdlc)]

There is not system status bar while the call in progress bar is displayed behind us

(In reply to Victoria Gerchinhoren [:vicky] from comment #9)
> Comment on attachment 8507758 [details]
> bar.png
> 
> Also, the system status bar should be visible, right?

Comment 11

[Cristian Rodriguez (:crdlc)]

(In reply to Victoria Gerchinhoren [:vicky] from comment #8)
> Comment on attachment 8507758 [details]
> bar.png
> 
> "hello" word should be regular style if text (400),

Firefox Hello is a placeholder and indivisible so same styles are applied for "Firefox" and "Hello"

> counter is missing and
> also, can you provide the screenshot of the case when the call is muted or
> on hold? I need to see how the respective icons are placed.

This will be done in another bug because it implies interaction and this bug only applies style to the current logic we already have 

> 
> Thanks!

Comment 12

[Cristian Rodriguez (:crdlc)]

Attachment: 1079782.png

thanks

Comment 13

[Cristian Rodriguez (:crdlc)]

I've already implemented all suggestions except comment 10 because of system status bar is invisible behind our call in progress bar. The counter is also available in this patch. Please see [1]

BTW we need to fill a new bug in order to know what the mute icon is [2]. Is this a button to mute/un-mute the call? is this just an icon to inform users about the current state without interaction (no touchable). Which assets will be used here? etc...

Maybe this questions are for Monica, right? Thanks a lot!

[1] https://bug1079782.bugzilla.mozilla.org/attachment.cgi?id=8507911
[2] https://bug1079782.bugzilla.mozilla.org/attachment.cgi?id=8501652

Comment 14

[Cristian Rodriguez (:crdlc)]

The ni? disappeared when I added the previous comment 13 :)

Comment 15

[Mónica UX/UI]

Hey,

"Connected" Status:
- Icons: Camera/Not Camera , Mute/Unmute + 00:00.

"Hold" Status: 
- String + Icon

Others Status:
- Only string.

And please C on Call with Capital Letter, please

Thanks :)

Comment 16

[Cristian Rodriguez (:crdlc)]

Attachment: status bar 9.png

:)

Comment 17

[Mónica UX/UI]

Attachment: Specs-Call-Status_Bar-Connected.pdf

Comment 18

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8508713 [details]
status bar 9.png

Cool! Thanks!

Comment 19

[Cristian Rodriguez (:crdlc)]

in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/113f28d0b89f86b3fd8fbcc5612846c21ca1f50f

Comment 20

[Maria Angeles Oteo (:oteo)]

Tested in master and working fine.
Although this is not a blocking issue the current call status bar in master looks a little ugly and Borja told me that the code was quite safe, so Cristian, let's go for the uplift!
Thanks a lot for your work and feedback!

Comment 21

[Cristian Rodriguez (:crdlc)]

in 1.1

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/48e1ae9f3e04a4598bf67a2667a05738dbaec5a2

Comment 22

[Loli (:lolimartinezcr)]

Attachment: 20141105_143152.jpg

Comment 23

[Loli (:lolimartinezcr)]

Attachment: 20141105_142852.jpg

Comment 24

[Loli (:lolimartinezcr)]

Tested. See attached image: 20141105_143152.jpg  and 20141105_142852.jpg 
Flame
eng
v2.0
Gecko-dde9d61
Gaia-7b8df99
Loop version: 1.1 , 2e7c3c2